Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Trap Handler #469

Merged
merged 7 commits into from
Jul 1, 2024
Merged

Conversation

UmerShahidengr
Copy link
Collaborator

This PR is coauthored by @allenjbaum, trap handler file (arch_tests.h) has the following changes:

  • converted one of the CANARY words to a delta instret count (there is a variable that will enable that)
  • converted CODE/DATA/SIG_BEGIN/END to include all the little incidental code, so the tests template improves
  • minor bug fixes to the trap handler in the cases of traps delegated to S-mode with virtualization enabled.
  • rewrote the identity map macro. The macro now takes 3 parameters: BASE, LVLS, PERMS and generates a page of PTE entries with the most significant PPN counting from 0..511 (or 1023 if RV32). The macro takes into account the 2 different PTE formats, based on XLEN. Whereever the macro is used, it defaults BASE to 0 (so VA==PA) and uses ALL_PERMS

allenjbaum
allenjbaum previously approved these changes Jul 1, 2024
Copy link
Collaborator

@allenjbaum allenjbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This passed Sail vs. Spike, so it should be good to go.

allenjbaum
allenjbaum previously approved these changes Jul 1, 2024
Copy link
Collaborator

@allenjbaum allenjbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This passed the Sail vs. Spike tests, so it should be good to go

Copy link
Collaborator

@jamesbeyond jamesbeyond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed in the ACT SIG meeting, good to go

@jamesbeyond jamesbeyond merged commit 13252e1 into riscv-non-isa:dev Jul 1, 2024
2 checks passed
@UmerShahidengr UmerShahidengr deleted the trap_handlr branch October 14, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants