-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Add ruff check #538
base: dev
Are you sure you want to change the base?
[CI] Add ruff check #538
Conversation
Before adding this to CI it should probably be added to the documentation. Otherwise many people contributing will not be aware of it and will not format their code properly which will cause CI to fail. It might also make sense to have an easy way for people who don't already have it installed to run ruff locally, maybe using pre-commit. |
This is a large PR, changing plugins, riscv-isac source code, adding new things in the installation guide, updating CI. All of these things have to be documented first, otherwise we will not be able to achieve good code formatting and CI will keep failing. |
Agree, I'm working on that, maybe added to CONTRIBUTION.md At the same time, I noticed that because many places in the code use This PR(include ci) does not perform any formatting(may be a few small places that I modified casually); the modifications are just to resolve lint errors or warnings. |
d5a280b
to
5662ff3
Compare
More commits here and I've allready test it with all cgfs for RV64 you can check current CI result at my fork repo https://github.com/trdthg/riscv-arch-test/actions
|
I will break this PR into some smaller parts |
…eval()` working correctly Signed-off-by: MingZhu Yan <[email protected]>
- Add precommit config - Update CONTRIBUTION.md, Add "Prepare" section Signed-off-by: MingZhu Yan <[email protected]>
Description
Currently, this PR includes the following content
Auto fix by ruff: Most of it is about imports
Manually fix
import *
with specific content==
->is
Bug fix
Add CI, currently only running the ruff check command, I would like to separate
ruff format --check
to the next PR