Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added requirement for 4B accesses to be atomic if 4B aligned #43

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

christian-herber-nxp
Copy link
Collaborator

No description provided.

Unverified

No user is associated with the committer email.
@christian-herber-nxp christian-herber-nxp linked an issue Jul 4, 2024 that may be closed by this pull request
@ved-rivos
Copy link
Collaborator

LGTM

@christian-herber-nxp christian-herber-nxp force-pushed the 34-clarify-memory-access-behavior branch from dc31b7d to c798edc Compare July 5, 2024 14:30
zilsd.adoc Outdated
*** If the effective address is 4B aligned:
**** The bytes are grouped into word accesses.
**** The words may be stored in any order.
**** The words may be grouped into larger accesses.
Copy link
Collaborator

@ved-rivos ved-rivos Jul 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets tighten this a bit. The words may be grouped into a doubleword. Just to avoid someone creating a 5B + 3B grouping.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that was unintended copy paste error. fixed

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should also be fixed for the stores.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, i did fix it but failed to push. i think it looks fine now

@christian-herber-nxp christian-herber-nxp marked this pull request as ready for review July 8, 2024 09:36
@christian-herber-nxp christian-herber-nxp merged commit 5654a38 into main Jul 9, 2024
1 check passed
@christian-herber-nxp christian-herber-nxp deleted the 34-clarify-memory-access-behavior branch July 9, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify memory access behavior
3 participants