poll: Translate voter names wrapped in parentheses

Signed-off-by: Zixuan James Li <[email protected]>
rishichirchi · Feb 7, 2025 · d0269ee · d0269ee
1 parent f71e036
commit d0269ee
Show file tree

Hide file tree

Showing 10 changed files with 50 additions and 2 deletions.
diff --git a/assets/l10n/app_en.arb b/assets/l10n/app_en.arb
@@ -746,6 +746,13 @@
   "@messageIsMovedLabel": {
     "description": "Label for a moved message. (Use ALL CAPS for cased alphabets: Latin, Greek, Cyrillic, etc.)"
   },
+  "pollVoterNames": "({voterNames})",
+  "@pollVoterNames": {
+    "description": "The list of people who voted for a poll option, wrapped in parentheses.",
+    "placeholders": {
+      "voterNames": {"type":  "String", "example": "Alice, Bob, Chad"}
+    }
+  },
   "pollWidgetQuestionMissing": "No question.",
   "@pollWidgetQuestionMissing": {
     "description": "Text to display for a poll when the question is missing"

diff --git a/lib/generated/l10n/zulip_localizations.dart b/lib/generated/l10n/zulip_localizations.dart
@@ -1101,6 +1101,12 @@ abstract class ZulipLocalizations {
   /// **'MOVED'**
   String get messageIsMovedLabel;
 
+  /// The list of people who voted for a poll option, wrapped in parentheses.
+  ///
+  /// In en, this message translates to:
+  /// **'({voterNames})'**
+  String pollVoterNames(String voterNames);
+
   /// Text to display for a poll when the question is missing
   ///
   /// In en, this message translates to:

diff --git a/lib/generated/l10n/zulip_localizations_ar.dart b/lib/generated/l10n/zulip_localizations_ar.dart
@@ -586,6 +586,11 @@ class ZulipLocalizationsAr extends ZulipLocalizations {
   @override
   String get messageIsMovedLabel => 'MOVED';
 
+  @override
+  String pollVoterNames(String voterNames) {
+    return '($voterNames)';
+  }
+
   @override
   String get pollWidgetQuestionMissing => 'No question.';
 

diff --git a/lib/generated/l10n/zulip_localizations_en.dart b/lib/generated/l10n/zulip_localizations_en.dart
@@ -586,6 +586,11 @@ class ZulipLocalizationsEn extends ZulipLocalizations {
   @override
   String get messageIsMovedLabel => 'MOVED';
 
+  @override
+  String pollVoterNames(String voterNames) {
+    return '($voterNames)';
+  }
+
   @override
   String get pollWidgetQuestionMissing => 'No question.';
 

diff --git a/lib/generated/l10n/zulip_localizations_ja.dart b/lib/generated/l10n/zulip_localizations_ja.dart
@@ -586,6 +586,11 @@ class ZulipLocalizationsJa extends ZulipLocalizations {
   @override
   String get messageIsMovedLabel => 'MOVED';
 
+  @override
+  String pollVoterNames(String voterNames) {
+    return '($voterNames)';
+  }
+
   @override
   String get pollWidgetQuestionMissing => 'No question.';
 

diff --git a/lib/generated/l10n/zulip_localizations_nb.dart b/lib/generated/l10n/zulip_localizations_nb.dart
@@ -586,6 +586,11 @@ class ZulipLocalizationsNb extends ZulipLocalizations {
   @override
   String get messageIsMovedLabel => 'MOVED';
 
+  @override
+  String pollVoterNames(String voterNames) {
+    return '($voterNames)';
+  }
+
   @override
   String get pollWidgetQuestionMissing => 'No question.';
 

diff --git a/lib/generated/l10n/zulip_localizations_pl.dart b/lib/generated/l10n/zulip_localizations_pl.dart
@@ -586,6 +586,11 @@ class ZulipLocalizationsPl extends ZulipLocalizations {
   @override
   String get messageIsMovedLabel => 'PRZENIESIONO';
 
+  @override
+  String pollVoterNames(String voterNames) {
+    return '($voterNames)';
+  }
+
   @override
   String get pollWidgetQuestionMissing => 'Brak pytania.';
 

diff --git a/lib/generated/l10n/zulip_localizations_ru.dart b/lib/generated/l10n/zulip_localizations_ru.dart
@@ -586,6 +586,11 @@ class ZulipLocalizationsRu extends ZulipLocalizations {
   @override
   String get messageIsMovedLabel => 'ПЕРЕМЕЩЕНО';
 
+  @override
+  String pollVoterNames(String voterNames) {
+    return '($voterNames)';
+  }
+
   @override
   String get pollWidgetQuestionMissing => 'Нет вопроса.';
 

diff --git a/lib/generated/l10n/zulip_localizations_sk.dart b/lib/generated/l10n/zulip_localizations_sk.dart
@@ -586,6 +586,11 @@ class ZulipLocalizationsSk extends ZulipLocalizations {
   @override
   String get messageIsMovedLabel => 'PRESUNUTÉ';
 
+  @override
+  String pollVoterNames(String voterNames) {
+    return '($voterNames)';
+  }
+
   @override
   String get pollWidgetQuestionMissing => 'Bez otázky.';
 

diff --git a/lib/widgets/poll.dart b/lib/widgets/poll.dart
@@ -126,8 +126,8 @@ class _PollWidgetState extends State<PollWidget> {
                 children: [
                   Text(option.text, style: textStyleBold.copyWith(fontSize: 16)),
                   if (option.voters.isNotEmpty)
-                    // TODO(i18n): Localize parenthesis characters.
-                    Text('($voterNames)', style: textStyleVoterNames),
+                    Text(zulipLocalizations.pollVoterNames(voterNames),
+                      style: textStyleVoterNames),
                 ]))),
         ]);
     }