feat(iceberg): support sql catalog interface #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenzl25
reviewed
Sep 18, 2024
Comment on lines
616
to
+623
| async fn create_table( | ||
| &self, | ||
| _namespace: &NamespaceIdent, | ||
| _creation: TableCreation, | ||
| namespace: &NamespaceIdent, | ||
| creation: TableCreation, | ||
| ) -> Result<Table> { | ||
| todo!() | ||
| if !self.namespace_exists(namespace).await? { | ||
| return no_such_namespace_err(namespace); | ||
| } |
There was a problem hiding this comment.
Could you please help to check when the catalog table iceberg_tables is created? Because when we use JNI catalog to create a table, it will initialize the catalog iceberg_tables (i.e. create table iceberg_tables) for us.
There was a problem hiding this comment.
There was a problem hiding this comment.
The catalog table iceberg_tables will be created when Create new sql catalog instance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing a partial implementation of sql catalog (support the functionality used by rw)