Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update generateArticle script extension to .js #1993

Closed
wants to merge 2 commits into from
Closed

chore: update generateArticle script extension to .js #1993

wants to merge 2 commits into from

Conversation

NathanFlurry
Copy link
Member

Changes

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Feb 3, 2025 •
edited
Loading

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: ec13538
Status: ✅  Deploy successful!
Preview URL: https://180406c4.rivet.pages.dev
Branch Preview URL: https://chore-update-generatearticle.rivet.pages.dev

View logs

This was referenced Feb 3, 2025
Closed
Closed
@NathanFlurry Graphite App
Copy link
Member Author

NathanFlurry commented Feb 3, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Feb 3, 2025
Closed
Closed
greptile-apps[bot]
greptile-apps bot reviewed Feb 3, 2025
View reviewed changes
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR modifies the article generation script extension in site/package.json from TypeScript (.ts) to JavaScript (.js).

  • Changed vite-node scripts/generateArticle.ts to vite-node scripts/generateArticle.js in site/package.json
  • Potential risk of losing TypeScript type safety benefits in the article generation script
  • Consider maintaining TypeScript for consistency with the rest of the codebase's type-safe approach
  • Recommend reviewing the actual script implementation to ensure proper error handling without TypeScript's safeguards
  • Suggest documenting rationale for moving away from TypeScript in this specific script

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@NathanFlurry NathanFlurry force-pushed the chore_update_generateArticle_script_extension_to_.js branch from 9ce0b4f to ff72dc5 Compare February 3, 2025 21:38
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Feb 3, 2025 •
edited
Loading

Deploying rivet-hub with  Cloudflare Pages  Cloudflare Pages

Latest commit: ff72dc5
Status: ✅  Deploy successful!
Preview URL: https://195e89d1.rivet-hub-7jb.pages.dev
Branch Preview URL: https://chore-update-generatearticle.rivet-hub-7jb.pages.dev

View logs

@NathanFlurry NathanFlurry mentioned this pull request Feb 3, 2025
Closed
@NathanFlurry NathanFlurry force-pushed the chore_update_generateArticle_script_extension_to_.js branch 6 times, most recently from 63b6659 to ff72dc5 Compare February 3, 2025 21:54
@NathanFlurry NathanFlurry force-pushed the 02-03-fix_toolchain_correctly_handle_current_tag_with_multiple_builds_with_the_same_name branch from 6d077e2 to c5ec7cb Compare February 4, 2025 02:00
@NathanFlurry NathanFlurry force-pushed the chore_update_generateArticle_script_extension_to_.js branch from 1ea411d to ec13538 Compare February 4, 2025 02:00
@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented Feb 4, 2025 •
edited
Loading

Merge activity

  • Feb 4, 1:42 AM EST: A user added this pull request to the Graphite merge queue.
  • Feb 4, 1:43 AM EST: CI is running for this PR on a draft PR: #1999
  • Feb 4, 1:44 AM EST: A user merged this pull request with the Graphite merge queue via draft PR: #1999.

graphite-app bot pushed a commit that referenced this pull request Feb 4, 2025
@NathanFlurry
chore: update generateArticle script extension to .js (#1993)
e65b5cb 
<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@graphite-app graphite-app bot deleted the branch 02-03-fix_toolchain_correctly_handle_current_tag_with_multiple_builds_with_the_same_name February 4, 2025 06:44
@graphite-app graphite-app bot closed this Feb 4, 2025
@graphite-app graphite-app bot deleted the chore_update_generateArticle_script_extension_to_.js branch February 4, 2025 06:44
@github-actions github-actions bot mentioned this pull request Feb 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NathanFlurry