-
-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rz_lang_byte_array and remove rz_print_code #2444
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart from a couple nitpicks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove all the n_bytes
arguments as they just provide a way to replace the blocksize, which can already be done with @!
.
Niiice anyway!
i had the same thought, but i wanted to double check with you |
Your checklist for this pull request
Detailed description
Book issue here: rizinorg/book#91
Extra tests have been added to cover all cases
Removed
pcA .bytes with instructions in comments
removes the dependency on RzCorepci C array of bytes with instructions
same reason aspcA
and was returning same output aspcA
pcs string
useless sinceps<cmd>
does the same and better.pcP python
alias forpcp
Moved
pcv JaVa
is nowpcJ
pcz Swift
is nowpcs
pcJ javascript
is nowpcn
because the output can be only used on NodeJS.pcS bash shellscript
is nowpcb
Added
pcg
for golang outputAlso almost all the outputs (with the exception of ObjC and Vlang) has been tested and validated.
New shell output