-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RzIL MIPS Uplifting #3508
base: dev
Are you sure you want to change the base?
RzIL MIPS Uplifting #3508
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend also to start cleaning up and extracting ESIL uplifting in librz/analysis/p/analysis_mips_cs.c
in separate functions, so that when time comes it can be removed quickly and painlessly.
Also, there are some tests in this file, that check mips.gnu
, we should make sure they pass with mips.cs
as well:
test/db/analysis/mips
99:e asm.arch=mips.gnu
121:e asm.arch=mips.gnu
527:e asm.arch=mips.gnu
748:NAME=mips.gnu regs
751:e asm.arch=mips.gnu
Or modified/removed
@brightprogrammer please maintain the current status/TODO in the PR description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please start adding tests. Otherwise you have a risk of writing a lot of wrong code.
Please maintain the list of instructions that are not uplifted yet. |
Uplifters for StoreOps and some Logical and Arithmetic Ops
You can remove |
Your checklist for this pull request
Detailed description
This PR is related to my GSoC 2023 summer project on MIPS uplifting. To view table of uplifted instructions, one can go here
Corresponding BAP's QEMU PR (for
rz-tracetest
) is BinaryAnalysisPlatform/qemu#26TODO
Test plan
Closing issues
Partially addresses #2080