Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated AArch64 RzAsm plugin from binutils #4064

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

XVilka
Copy link
Member

@XVilka XVilka commented Jan 3, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

After Capstone auto-sync is completed for AArch64 this plugin is unnecessary now.

Test plan

CI is green

Closing issues

Copy link
Member

@Rot127 Rot127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
<3

@XVilka
Copy link
Member Author

XVilka commented Jan 3, 2024

NetBSD CI is flaky today, rz-bindgen worker error is unrelated:

 /usr/bin/python3 ../src/main.py -o . --clang-path /usr/lib/llvm-14/lib --clang-args ' -resource-dir="/usr/lib/llvm-14/lib/clang/14.0.0"' --rizin-include-path /usr/include/librz --targets SWIG
Warning:  Ignored fields on class RzIO do not exist: priv_w32dbg_wrap
Traceback (most recent call last):
  File "/home/runner/work/rizin/rizin/rz-bindgen/build/../src/main.py", line 57, in <module>
    generator_swig.generate(output_dir)
  File "/home/runner/work/rizin/rizin/rz-bindgen/src/generator_swig.py", line 37, in generate
    write(Writer(output_file))
  File "/home/runner/work/rizin/rizin/rz-bindgen/src/generator_swig.py", line 61, in write
    write_class(writer, cls)
  File "/home/runner/work/rizin/rizin/rz-bindgen/src/generator_swig.py", line 211, in write_class
    decl = stringify_decl(field.name, field.ctype)
  File "/home/runner/work/rizin/rizin/rz-bindgen/src/generator_swig.py", line 165, in stringify_decl
    return f"{class_structs[ctype.decl_spelling].name} {expr}"
KeyError: 'rz_analysis_esil_inter_state_t'

@XVilka XVilka merged commit e34e6ab into dev Jan 3, 2024
59 of 61 checks passed
@XVilka XVilka deleted the dist-remove-gnu-aarch64 branch January 3, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants