Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix meson-build global_arguments #4698

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix meson-build global_arguments #4698

wants to merge 1 commit into from

Conversation

amibranch
Copy link
Contributor

@amibranch amibranch commented Nov 3, 2024 •
edited
Loading

  • Added a CI-task to check if rizin could be used as subproject
  • Fixed some new global-arguments in meson-build

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

It happened again...

This makes it (again) impossible to add rizin as subproject.

Test plan

To avoid any further regressions, a CI-Task is proposed herein.

The task really just tests if it is possible to use a branch/PR of rizin as subproject. It (currently) wouldn't check for any linker-problems or API-stability as there is no such guaranty in that setup.

Closing issues

Partially addresses #3454

Also:

  • The integration tests will be excluded herein, if rizins CLI is disabled by build-configuration. In this case no rizin-binary is available that could be used for the Integration-tests.

@amibranch amibranch force-pushed the dist-add_subproject_test branch 2 times, most recently from 6d82baa to 84398aa Compare November 3, 2024 19:40
@amibranch amibranch marked this pull request as draft November 3, 2024 19:41
@amibranch amibranch force-pushed the dist-add_subproject_test branch 10 times, most recently from 99f8713 to 93b6425 Compare November 3, 2024 21:13
@amibranch amibranch marked this pull request as ready for review November 3, 2024 21:32
wargio
wargio reviewed Nov 6, 2024
View reviewed changes
.github/subproject_test/meson.build Outdated
# TODO: extend to perform actually linking test as well!
tester_source = custom_target('main.c',
command: ['echo', '''
#include <stdio.h>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add rz_core.h instead of stdio.h and call rz_cons_printf

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be easily done. However, note that any actual linker- or compiler-time-dependency has been avoided here intentionally as it will always be partial and I'm not sure if there is any guarantee by rizin to provide stability here (despite the stability of rz_cons_printf could be easily assumed)?

wargio
wargio requested changes Nov 6, 2024
View reviewed changes
Copy link
Member

@wargio wargio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add the changes to the test and i think is ok to merge

@amibranch
Copy link
Contributor Author

Just add the changes to the test and i think is ok to merge

Could you be more specific which test do you mean? The standard CI-tasks?

@amibranch amibranch force-pushed the dist-add_subproject_test branch 2 times, most recently from 637811d to da76065 Compare November 6, 2024 16:11
@wargio
Copy link
Member

wargio commented Nov 7, 2024

Just add the changes to the test and i think is ok to merge

Could you be more specific which test do you mean? The standard CI-tasks?

i was exactly referring to the changes that you have pushed.

@amibranch
build: Fix meson-build global_arguments
8a6137e 
* Added a CI-task to check if rizin could be used as subproject
* Fixed some new global-arguments in meson-build
@amibranch
Copy link
Contributor Author

Branch squashed and rebased

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wargio wargio wargio requested changes

@XVilka XVilka Awaiting requested review from XVilka XVilka is a code owner

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
infrastructure rz-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amibranch @wargio