-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build due to ht_*.h
move and non-use of llvm-config
#37
Conversation
a590739
to
8a23279
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"C:\Users\runneradmin\AppData\Local\Temp\cibw-run-tma2clor\cp38-win_amd64\build\venv\Scripts\python.exe" "../src/main.py" "-o" "." "--clang-path" "C:/Program Files/LLVM/bin" "--clang-args" " -resource-dir=C:/Program Files/LLVM/lib/clang/16" "--rizin-include-path" "C:rizin/include/librz" "--targets" "SWIG"
warning: Files/LLVM/lib/clang/16: 'linker' input unused [-Wunused-command-line-argument]
warning: Files/LLVM/lib/clang/16: 'linker' input unused [-Wunused-command-line-argument]
warning: Files/LLVM/lib/clang/16: 'linker' input unused [-Wunused-command-line-argument]
Traceback (most recent call last):
File "../src/main.py", line 51, in <module>
bindings.run()
File "D:\a\rz-bindgen\rz-bindgen\src\bindings.py", line 51, in run
func(Header(translation_unit, builder))
File "D:\a\rz-bindgen\rz-bindgen\src\cparser_header.py", line 177, in __init__
prev = self.cursors[cursor.kind][name]
KeyError: 'RzAnalysisMetaUserItem'
ninja: build stopped: subcommand failed.
INFO: autodetecting backend as ninja
INFO: calculating backend command to run: C:\hostedtoolcache\windows\Python\3.7.9\x64\Scripts\ninja.EXE
error: subprocess-exited-with-error
https://github.com/rizinorg/rz-bindgen/actions/runs/6642695802/job/18048044959?pr=37#step:4:4045
Redness of Windows and Python linting builds appear to be unrelated |
the python lint issue is just a matter of config. add |
The binding for windows is broken because of this
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!! Thanks a lot @kazarmy
The Clang path didn't change between the last Windows green build on master and the broken Windows build here so I'm pretty sure it's not me that caused the regression (unfortunately), therefore I'm merging this so that at least the Linux version builds. |
This pr should fix the broken build due to
(https://github.com/rizinorg/rizin/actions/runs/6613041973/job/17960372892#step:7:46)
and #35, and should close #35, by changing some paths and using
llvm-config
(as per README.md) instead of whatever it's using right now.