Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build job ubuntu-llvm-15 #44

Merged
merged 4 commits into from
Dec 2, 2023
Merged

Add build job ubuntu-llvm-15 #44

merged 4 commits into from
Dec 2, 2023

Conversation

kazarmy
Copy link
Member

@kazarmy kazarmy commented Dec 2, 2023

This pr adds a new build job that uses LLVM 15, because the LLVM version used in the pypa-wheels Ubuntu build is really old (LLVM 7). Also, the pypa-wheels Ubuntu build doesn't use the same steps as in the Rizin CI while this job practically does.

@kazarmy kazarmy marked this pull request as draft December 2, 2023 13:08
@kazarmy kazarmy marked this pull request as ready for review December 2, 2023 13:41
Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if green. Getting different LLVM versions working is tricky though.

@kazarmy
Copy link
Member Author

kazarmy commented Dec 2, 2023

I probably won't add a build for LLVM 14 even though it's the default LLVM version of Ubuntu 22.04.

@kazarmy kazarmy merged commit 98ec554 into master Dec 2, 2023
8 checks passed
@kazarmy kazarmy deleted the ubuntu-llvm-15 branch December 2, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants