Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use manylinux2014 base image instead #62

Merged
merged 20 commits into from
Apr 18, 2024
Merged

Use manylinux2014 base image instead #62

merged 20 commits into from
Apr 18, 2024

Conversation

kazarmy
Copy link
Member

@kazarmy kazarmy commented Apr 18, 2024

This pr uses the manylinux2014 base image instead of manylinux_2_24 because the latter is EOL. The manylinux_2_24 base image was chosen over manylinux_2_28 because the latter doesn't have an i686 image.

@kazarmy kazarmy marked this pull request as draft April 18, 2024 09:15
@kazarmy
Copy link
Member Author

kazarmy commented Apr 18, 2024

Unfortunately it appears that i686 support will need to be dropped, since there doesn't seem to be a quick way to obtain i686 CentOS 7 clang binaries. I still think manylinux2014 should be used instead of manylinux_2_28 since it's older (and besides I don't want to go through the above again, at least for now).

@XVilka
Copy link
Member

XVilka commented Apr 18, 2024

Unfortunately it appears that i686 support will need to be dropped, since there doesn't seem to be a quick way to obtain i686 CentOS 7 clang binaries. I still think manylinux2014 should be used instead of manylinux_2_28 since it's older (and besides I don't want to go through the above again, at least for now).

I think it is fine to drop i686 for bindings, if anyone needs them for such a specific case they can build bindings themselves.

@wargio
Copy link
Member

wargio commented Apr 18, 2024

i don't think we should keep support for 32 bit x86.

@kazarmy kazarmy marked this pull request as ready for review April 18, 2024 14:57
@kazarmy kazarmy requested review from XVilka and wargio April 18, 2024 14:57
@kazarmy
Copy link
Member Author

kazarmy commented Apr 18, 2024

Ok done. The upload-artifact problem appears unrelated.

@kazarmy kazarmy merged commit d00a7e9 into master Apr 18, 2024
8 checks passed
@kazarmy kazarmy deleted the manylinux2014 branch April 18, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants