Fix: Avoid compiling Peep.Plug
when Plug module is not present
#26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there and Happy new year! 🎉
I noticed
plug
is marked as optional in the mix.exs however the lib doesn't compile whenplug
is not present.I wrapped
Peep.Plug
around a conditional(if Code.ensure_loaded?(Plug)
so it doesn't try to create that module whenplug
is not present.An alternative would be to remove the
optional
part from themix.exs
.