-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rules concepts] Add triggers & conditions #4
Conversation
Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: Florian Hotze <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Over all it looks really good. Thanks for submitting. Most of these comments are nit picking but I think they are important.
Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: Florian Hotze <[email protected]>
@rkoshak |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I've just a few typos and word order type comments and we are good to merge. Thanks again for working on this. I keep trying to find an hour where I can sit in front of a computer to type something out but it's not worked out yet.
I do get an alert through the Github app on my phone when it's a PR or issue I'm subscribed to or am mentioned in a comment. I also check the list of issues and PRs in my github notifications every couple of days. But I like to dedicate a contiguous time to do reviews like this which can delay my response.
Signed-off-by: Florian Hotze <[email protected]>
You are welcome. I know the problem with the time, luckily I have school holidays and some time to work on this. |
Can you please update the issue and tick the checkboxes for 1b and 1c? |
Yes, already have it open, just got distracted for a bit. |
@rkoshak
Unfortunately I have bad weather today on my vacation trip, so this is the next microstep in reworking the rule documentation.
This PR should complete part 1b and 1c of openhab#1855.