parse no_mangle in cfg_attr #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes rksm#36 the predicate currently isn't checked, which may cause false positives, but this is very unlikely to happen and this can be dealt with in the future. the relevant documentation and example have been adjusted. the documentation for #[no_mangle_if_debug] has been removed since it doesn't work with optimizations or the feature flag anyways. it should later be deprecated and phased out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #36
the predicate currently isn't checked, which may cause false positives, but this is very unlikely to happen and this can be dealt with in the future.
i removed the documentation for #[no_mangle_if_debug] since it doesn't work with optimizations or the feature flag anyways. i think it should be deprecated.