forked from numpy/numpy
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pypy hack #3
Open
mattip
wants to merge
11
commits into
rlamy:pypy-hack
Choose a base branch
from
mattip:pypy-hack
base: pypy-hack
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Pypy hack #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- numpy/lib/utils.py: get_include() now calls numpypy.get_include(). - numpy/core/fromnumeric.py: Add implementations for np.take() and np.ptp(). - numpy/distutils/misc_utip.py: Add comment what was done to deactivate building of external modules. - numpy/f2py/rules.py: Replace array->data calls in wrapper generator by PyArray_DATA(array).
- numpy/f2py/f90mod_rules.py: Replace "np.intp().itemsize" by "np.dtype('intp').itemsize", since the latter is supported by PyPy. - numpy/f2py/src/fortranobject.c: check_and_fix_dimensions(): Refactor using PyArray_NDIM() and PyArray_DIM() instead of direct field access. Tested by recompiling and testing CPython numpy. Works.
- const PyArrayObject -> ArrayObject - Use PyArray_ISCONTIGUOUS(), PyArray_FLAGS() - Replace PyArray_MultiplyList() by direct loop. - Deactivate swap_arrays() for now. - PyArray_Size((PyObject*)arr) -> PyArray_Size(arr).
- Manually copy arr->dimensions into array arr_dims[]. - Replace PyArray_FromAny() by PyArray_FROM_OTF(), to avoid the need to create a PyArray_Descr instance. - Replace PyArray_DescrFromType() to investigate element size by PyArray_SimpleNew() + PyArray_ITEMSIZE(). - Modify docstrings and error messages that output character codes arr->descr->type, which are impossible to get with PyPy.
- numpy/linalg/lapack_lite.py: Delete placeholder file. - numpy/distutils/misc_util.py: Add 'activate' flag to selectively activate building of a module. Use in numpy/linalg/setup.py. Note that numpy/core/include must be renamed so that the PyPy headers are found. - numpy/core/multiarray.py: Add implemenations for copyto() and fastCopyAndTranspose(). - numpy/core/numeric.py: ones(): Use numpypy's implementation.
rlamy
pushed a commit
that referenced
this pull request
Nov 23, 2021
commit 9c833bed5879d77e625556260690c349de18b433 Author: Thomas Li <[email protected]> Date: Wed Nov 17 16:21:27 2021 -0800 Add Windows config to GHA update script [wheel build] typo [wheel build] fix typo? [wheel build] fix linux builds? [wheel build] typo [wheel build] add license and pin to windows 2016 skip tests [wheel build] pin to windows 2019 instead [wheel build] try to find out the error on windows [wheel build] maybe fix? [wheel build] maybe fix? [wheel build] fix? [wheel build] cleanup [wheel build] Add Windows config to GHA update script [wheel build] typo [wheel build] fix typo? [wheel build] fix linux builds? [wheel build] typo [wheel build] add license and pin to windows 2016 skip tests [wheel build] pin to windows 2019 instead [wheel build] try to find out the error on windows [wheel build] maybe fix? [wheel build] maybe fix? [wheel build] fix? [wheel build] cleanup [wheel build] Update LICENSE_win32.txt Update LICENSE_win32.txt Add Windows config to GHA update script [wheel build] typo [wheel build] fix typo? [wheel build] fix linux builds? [wheel build] typo [wheel build] add license and pin to windows 2016 skip tests [wheel build] pin to windows 2019 instead [wheel build] try to find out the error on windows [wheel build] maybe fix? [wheel build] maybe fix? [wheel build] fix? [wheel build] cleanup [wheel build] Update LICENSE_win32.txt Update LICENSE_win32.txt Update cibw_test_command.sh commit 4bd12df Author: Thomas Li <[email protected]> Date: Mon Nov 15 17:28:47 2021 -0800 # This is a combination of 14 commits. # This is the 1st commit message: Add Windows config to GHA # This is the commit message #2: update script [wheel build] # This is the commit message #3: typo [wheel build] # This is the commit message #4: fix typo? [wheel build] # This is the commit message #5: fix linux builds? [wheel build] # This is the commit message #6: typo [wheel build] # This is the commit message #7: add license and pin to windows 2016 # This is the commit message #8: skip tests [wheel build] # This is the commit message #9: pin to windows 2019 instead [wheel build] # This is the commit message numpy#10: try to find out the error on windows [wheel build] # This is the commit message numpy#11: maybe fix? [wheel build] # This is the commit message numpy#12: maybe fix? [wheel build] # This is the commit message numpy#13: fix? [wheel build] # This is the commit message numpy#14: cleanup [wheel build]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add lapack_lite which uses c api, using this and https://github.com/mattip/matplotlib I can now do 'import pylab' but matplotlib tests fail. I committed a change to pypy to hopefully fix one missing feature toward passing the first test.