Added IP info to sys_info.py #165
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added IP info to the sys_info.py example. Also included a caching (default: 4 hours) since IP address is not something that changes frequently.
Changed the strategy for failure cases. Now returning an empty string and (hopefully) ensuring nothing else will go wrong (like failing to display None).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added IP info to the
sys_info.pyexample. Also included a caching (default: 4 hours) since IP address is not something that changes frequently.If something goes wrong, the line will be blank.
The rationale for this change is that the IP being displayed is super useful information to have at hand and goes well with all the other stats printed in this example.