Fix plugin short name parsing for records that contain the zone name more than once #586
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #584
Many DNS plugins use a regex based algorithm documented in the plugin development guide to separate a record label (short name) from its zone name. The previous version of this algorithm didn't account for the edge case where the FQDN might contain the zone name more than once in the string.
So a record like
_acme-challenge.example.com.foo.example.com
in a zone calledexample.com
would result in a short name of_acme-challenge..foo
instead of_acme-challenge.example.com.foo
preventing the proper creation of the associated TXT record with that provider.This change fixes that bug in all of the plugins currently implementing it and in the plugin development guide.
Thanks to @andreashaerter for finding the original bug.