Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fog support, Draw distance cutoff #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tklajnscek
Copy link

Robert, I've added support for fog so that the lights shafts fade into it nicely. I also added a draw distance parameter to stop drawing the effect beyond a certain distance as a performance optimization. Tried to keep the changes as minimal as possible. Feel free to use any parts of it if you feel like it's useful for you :)

Log:

  • Support fading into fog (all Unity fog modes supported, using shader keywords to optimize shader runtime)
  • Added 'Draw distance' parameter to stop the effect from rendering after a certain distance from the camera. Hardcoded fade out at the final 10% of the range for now.

…keywords to optimize shader runtime)

Added 'Draw distance' parameter to stop the effect from rendering after a certain distance from the camera. Hardcoded fade out at the final 10% of the range for now.
@robcupisz
Copy link
Owner

Thanks, good stuff :)

I think I'll refrain from merging it to keep light shafts from being bloated - there's dozens of little features like that which could be added ;) So if someone will need these particular changes, they'll get them from your pr.

@TimNick151297
Copy link

Hi Robert, is it possible to add lightshafts for point lights? :) Would be cool, if a point light could also cast realtime lightshafts :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants