Added language setting. #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roberthartung
requested changes
Sep 26, 2017
lib/charts.dart
Outdated
| @@ -48,18 +48,13 @@ abstract class Chart { | |||
| jsChart.callMethod('clearChart'); | |||
| } | |||
|
|
|||
| static Future load({List<String> packages, String version: "current"}) { | |||
| static Future load({List<String> packages, String version: "current", String language}) { | |||
There was a problem hiding this comment.
language should have a default value or be before the version parameter!
There was a problem hiding this comment.
No default value must be set since the js lib will try to find the best match for the language option when no language option is provided. Wasn't aware optional parameters which do not have a default values should be placed before those which do. Will change.
lib/charts.dart
Outdated
| if (packages != null) argsMap["packages"] = packages; | ||
| if (language != null) argsMap["language"] = language; | ||
|
|
||
| JsObject args = new JsObject.jsify({'callback': new JsFunction.withThis(c.complete)}); |
lib/visualization.dart
Outdated
| @@ -70,18 +70,13 @@ abstract class Chart { | |||
| jsChart.callMethod('clearChart'); | |||
| } | |||
|
|
|||
| static Future load({List<String> packages, String version: "current"}) { | |||
| static Future load({List<String> packages, String version: "current", String language}) { | |||
| if (packages != null) argsMap['packages'] = packages; | ||
| if (language != null) argsMap['language'] = language; | ||
|
|
||
| JsObject args = new JsObject.jsify(argsMap); |
There was a problem hiding this comment.
Callback is already added to the argsMap.
|
Changes committed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the language setting to the load function.