-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI integration #154
Merged
Merged
CI integration #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrey Milko <[email protected]>
apmilko
commented
May 13, 2024
apmilko
commented
May 13, 2024
По поводу бага с eigen3 - надо поправить в мастере |
apmilko
commented
May 15, 2024
Config is default except one param 'dangle_parens = True', which is used by next rule: if a statement is wrapped to more than one line, than dangle the closing parenthesis on its own line. Exclude file ".cmake-format.py" for hook "ruff".
BreakBeforeBinaryOperators: NonAssignment
apmilko
commented
May 15, 2024
BreakConstructorInitializers: AfterColon
AndBondStyle
approved these changes
May 15, 2024
Signed-off-by: Andrey Milko <[email protected]>
Signed-off-by: Andrey Milko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Интеграция CI, сделано полностью как в репозитории handy, но с парой уточнений.
Основные этапы:
DONE
] Джоба для запуска пре-коммитаTODO
] Джоба для сборки проекта и запуска тестовДжоба для запуска пре-коммита:
clang-format
(types_or
вместоtypes
), из-за которой множество файлов для запуска проверки определялось не корректноyamlint
лишнюю преписку.git
--enforce-all
(для проверки всех файлов в репозитории),--maxkb=12300
(см. комментарий).yamllint-config.yaml
максимальная длина строки изменена с 120 до 180 (см. комментарий)Passed