Add yarp-ros repo with Unstable branches and compile again against YARP master in Unstable branches #1547
+92
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build fails with: The problem is that both |
traversaro
added a commit
that referenced
this pull request
Nov 28, 2023
Until the yarp-ros situation described in #1547 (comment) is fixed.
traversaro
force-pushed
the
addyarpros
branch
from
697ffb9
to
bfbb406
Compare
This was fixed by robotology/yarp-ros#19 . |
|
Ok, I removed the pin of yarp-3.9 branch in the Unstable branch, as this PR should now ready to merge. Unfortunately, this means that probably we will hit ~3 months backlog of regression due to the changes of YARP, some of which already hit @S-Dafarra . The first one is in Debian buster: This was kind of expected. We already discussed about this with core and it basically means that we will stop supporting pc104 systems (see https://icub-tech-iit.github.io/documentation/icub_operating_systems/download/) when using YARP 3.10, and I think it was agreed this was ok (fyi @Nicogene @pattacini). |
|
We also have the same problem in Focal: For what regards focal, we are not ready to drop 20.04 support (see #1439), so for patching focal probably we can install a newer CMake via either backports or kitware repo. |
traversaro
changed the title
|
Ok, now I see the error: That I guess is what @S-Dafarra was reporting. |
Indeed. Related issues: |
|
Would it be possible to add also https://github.com/robotology/yarp-devices-ros? |
Sure, I did not realized that was a different repo as well. |
|
Now there are a bunch of failures in icub-basic-demos: |
|
@SimoneMic @GiulioRomualdi @S-Dafarra I refreshed this PR for YARP master (future 3.10) support, and currently there are a few compilation error in icub-basic-demos, that you can find in the previous comment. Probably this errors are not found if |
|
On, now the only remaining problems are:
|
This problem was fixed in robotology/yarp#3097, but I guess the fix was never forward-merged in yarp |
I think that is just an effect, the real error is: I guess that teh |
|
I heard from two developers in the last week that they had problems of compatibility due to this, let's try to wrap it up (also in view of a possible YARP 3.10.0 release). |
vcpkg build is not frequently use, I guess we can just add the right path in the CI script. |
Workaround added in 9b6fe9d . |
This was fixed in robotology/yarp@ac4b416, the merge yarp-3.9 --> master was broken and now it should work fine. |
|
New failure: I think I already solved this in the past. |
This is a similar failure that currently is in I think that neither |
|
Thanks, I was actually confusing it with robotology/gazebo-yarp-plugins#690 that was for sure easier. |
|
Fix provided in robotology/yarp-devices-ros#3 . |
|
New fix robotology/gz-sim-yarp-plugins#217 (fyi @xela-95 can you quicky check the PR so we can unblock this one? Thanks!) |
Done! |
Thanks! |
|
Finally green! |
|
Actually not, still a Windows error after 1.5 h of CI: |
|
The actual error is: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1536 .
Changes necessary to support modern YARP:
This PR also adds a
ROBOTOLOGY_SUPERBUILD_BUILD_SEPARATE_YARP_ROSCMake option, that isONby default when used withROBOTOLOGY_PROJECT_TAGSset toUnstable, but that can be manually enable if users want to setYCM_EP_DEVEL_MODE_YARPtoONand manually switch to useYARPmaster and the future YARP 3.10.fyi @SimoneMic @GiulioRomualdi @S-Dafarra