-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typehints #208
base: master
Are you sure you want to change the base?
Typehints #208
Conversation
Codecov Report
@@ Coverage Diff @@
## master #208 +/- ##
=========================================
Coverage ? 69.28%
Complexity ? 402
=========================================
Files ? 5
Lines ? 1133
Branches ? 0
=========================================
Hits ? 785
Misses ? 348
Partials ? 0 |
This is only half the work.. I took out the low hanging fruit, but the remaining Psalm-issues should be addressed |
@tvdijen I am just going to hang on to this until I am considering a 4.x branch. There are too many BC breaking changes. I will go through the type hint only change to see if that might be able to be applied. May also grab some of your changes that fix codecov as well. |
Yes, the downside of changes like this it that it touches literally every method/file, but the benefits for fully typehinting a library like this are huge.. |
This is a good start into PHP 7.1 and PSR-12 compliancy.. Some Psalm-issues remain