Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enc, DSig: Add public preserveWhiteSpace and formatOutput switches #221

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sprytnyserek
Copy link

This is somehow related to following issues and pull requests:

I propose to enable ability to skip whitespaces and formatting from the XML Enc and Sig templates using the generic options from DOMDocument class: preserveWhiteSpace and formatOutput, and make it configurable with options with the same names. Current behavior is set as default one.

Some relying parties may be highly sensitive to redundant spaces, tabs and newlines in the XML payload while they can (and should) be considered as true XML text nodes. It appears in e.g. WSFed module in .NET Core 3.1 and .NET 5.

Enabling solution like this to the upstream brings no risk to existing relying solutions.

@tvdijen
Copy link
Contributor

tvdijen commented Dec 9, 2021

Hi @robrichards ! You see any problem merging this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants