Enc, DSig: Add public preserveWhiteSpace and formatOutput switches #221
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is somehow related to following issues and pull requests:
I propose to enable ability to skip whitespaces and formatting from the XML Enc and Sig templates using the generic options from DOMDocument class: preserveWhiteSpace and formatOutput, and make it configurable with options with the same names. Current behavior is set as default one.
Some relying parties may be highly sensitive to redundant spaces, tabs and newlines in the XML payload while they can (and should) be considered as true XML text nodes. It appears in e.g. WSFed module in .NET Core 3.1 and .NET 5.
Enabling solution like this to the upstream brings no risk to existing relying solutions.