fix: allow overriding mimir headers #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
chris-parker-za
approved these changes
Feb 7, 2025
|
When can we expect this fix to be merged? Currently this is blocking mimir instances that don't use anonymous from working at all. |
|
@chris-parker-za thank you for bumping this. Its merged and will be included in the next release. |
|
Happy to help! Glad it's approved finally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When connecting to Mimir the
X-Scope-OrgID: anonymoustenant header is automatically set. However, when using the--prometheus-headersflag to set a custom value for this it isn't propagated. This change ensures that headers set through the cli flags overwrite anyadditional_headersspecified in the code.