code style improvements

roc-lang · Feb 9, 2024 · e995c7c · e995c7c
1 parent 8547b50
commit e995c7c
Showing 1 changed file with 8 additions and 9 deletions.
diff --git a/platform/Utc.roc b/platform/Utc.roc
@@ -62,17 +62,16 @@ fromNanosSinceEpoch = @Utc
 
 ## Calculate milliseconds between two Utc timestamps
 deltaAsMillis : Utc, Utc -> U128
-deltaAsMillis = \@Utc first, @Utc second ->
-    firstCast = Num.bitwiseXor (Num.toU128 first) (Num.shiftLeftBy 1 127)
-    secondCast = Num.bitwiseXor (Num.toU128 second) (Num.shiftLeftBy 1 127)
-    (Num.absDiff firstCast secondCast) // nanosPerMilli
+deltaAsMillis = \utcA, utcB ->
+    (deltaAsNanos utcA utcB) // nanosPerMilli
 
 ## Calculate nanoseconds between two Utc timestamps
 deltaAsNanos : Utc, Utc -> U128
-deltaAsNanos = \@Utc first, @Utc second ->
-    firstCast = Num.bitwiseXor (Num.toU128 first) (Num.shiftLeftBy 1 127)
-    secondCast = Num.bitwiseXor (Num.toU128 second) (Num.shiftLeftBy 1 127)
-    Num.absDiff firstCast secondCast
+deltaAsNanos = \@Utc nanosA, @Utc nanosB ->
+    # bitwiseXor for best performance
+    nanosAShifted = Num.bitwiseXor (Num.toU128 nanosA) (Num.shiftLeftBy 1 127)
+    nanosBShifted = Num.bitwiseXor (Num.toU128 nanosB) (Num.shiftLeftBy 1 127)
+    Num.absDiff nanosAShifted nanosBShifted
 
 # TESTS
 expect deltaAsNanos (fromNanosSinceEpoch 0) (fromNanosSinceEpoch 0) == 0
@@ -84,4 +83,4 @@ expect deltaAsMillis (fromMillisSinceEpoch 0) (fromMillisSinceEpoch 0) == 0
 expect deltaAsMillis (fromNanosSinceEpoch 1) (fromNanosSinceEpoch 2) == 0
 expect deltaAsMillis (fromMillisSinceEpoch 1) (fromMillisSinceEpoch 2) == 1
 expect deltaAsMillis (fromMillisSinceEpoch -1) (fromMillisSinceEpoch 1) == 2
-expect deltaAsMillis (fromNanosSinceEpoch Num.minI128) (fromNanosSinceEpoch Num.maxI128) == Num.maxU128 // nanosPerMilli
+expect deltaAsMillis (fromNanosSinceEpoch Num.minI128) (fromNanosSinceEpoch Num.maxI128) == Num.maxU128 // nanosPerMilli