Improve rock hz #30
Improve rock hz #30
Conversation
And offer the --pull option to use a pulling connection
| one_s = compute_frequency(now, one_s_queue, 1) | ||
| ten_s = compute_frequency(now, ten_s_queue, 10) | ||
|
|
||
| # Terminal code to go up 1 line and clear the line |
There was a problem hiding this comment.
The comment is still there, but the corresponding code not.
I would want to keep the in place update for the terminal as it was before
There was a problem hiding this comment.
What sucks with the in-place update is that one does not see how the frequency progresses.
There was a problem hiding this comment.
I don't really like the running console - and even for your purpose, if you want to display and analyse the frequency progress, then why not use a better readable output format or log file that can readily be used for gnuplot?
| @@ -30,57 +38,53 @@ if !(options[:task_name] || options[:port_name]) | |||
| exit | |||
| end | |||
|
|
|||
| require 'orocos' | |||
There was a problem hiding this comment.
Loading orocos after the options block has been done due to the fact that loading takes some time and waiting for the help message for few seconds does not give a good user experience.
There was a problem hiding this comment.
does not give a good user experience.
.... I'll refrain from commenting on that.
There was a problem hiding this comment.
Could you actually run time ruby -e "require 'orocos'" on your machine ?
There was a problem hiding this comment.
First time load and 2 subsequent ones: Ubuntu 14.04, ruby2.0
ruby -e "require 'orocos'" 0.74s user 0.15s system 37% cpu 2.374 total
$ time ruby -e "require 'orocos'"
ruby -e "require 'orocos'" 0.46s user 0.04s system 98% cpu 0.508 total
$ time ruby -e "require 'orocos'"
ruby -e "require 'orocos'" 0.44s user 0.05s system 99% cpu 0.495 total
There was a problem hiding this comment.
ruby -e "require 'orocos'" 0.74s user 0.15s system 37% cpu 2.374 total
So, cold cache, never loaded orocos.rb, 2.3 seconds. I doubt that rock-hz is really going to be the very first orocos-related command you'll run on a fresh machine. Then 0.5 seconds. Is that really worth duplicating every single command-line option in an option hash to then apply them ?
This adds a few features to rock-hz: - without arguments, or if the given task/port do not match an existing one, the script now lists matching tasks/ports and lets the user choose one. This is currently buggy if there is more tasks than one page, but IMO it's still much better than the current situation of having to figure out task and port names and type them. - the display uses the TTY gem instead of hardcoding ANSI codes, and formats the output as a table without having a running console - with the -c COUNT option, it shows a history of the values
|
Pushed some other improvements. It reestablishes the non-running console. Given that the loading time of |
|
K, thx. Looks fine to me. |
Depends on rock-core/package_set#106
This fixes the way rock-hz was doing its averaging (which was really not working well), and adds the --host option.
In addition, it improves the UI:
one, the script now lists matching tasks/ports and lets the user
choose one. This is currently buggy if there is more tasks than
one page, but IMO it's still much better than the current situation
of having to figure out task and port names and type them.
codes, and formats the output as a table without having a running
console