Enable qt4-qt5 setup #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qt5:: seems to be more compatible.
Archive is currently unavailable and switching to the osdep (liblemon-dev v1.3.1) seems to be the first choice now. However, lemon.pc requires further patching, since it requires linking of -lemon and not -llemon.
It is part of the qt5 dependency.
| @@ -1,6 +1,9 @@ | |||
| find_package(Boost REQUIRED filesystem system serialization) | |||
| find_package(SCIP) | |||
|
|
|||
| rock_find_qt4(OPTIONAL QtGui QtSvg) | |||
| rock_find_qt5(OPTIONAL Gui Svg Widgets PrintSupport) | |||
There was a problem hiding this comment.
For Qt4, QtGui(and QtCore, QtOpenGL) and for Qt5, Gui, Widgets(and Core, OpenGL) are added to components by default. This does no harm, though.
pierrewillenbrockdfki
approved these changes
Jul 25, 2024
|
@pierrewillenbrockdfki thx for checking and all your qt work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revised naming schema of the libraries: