add at_least_until to the maintain expectation

[g-arjones]

The plan is to add this to Syskit's have_no_new_sample helper if the concept and implementation are ok

[doudou]

In principle, there's nothing wrong with it. I'd just want to be sure it's not something one can do already.

How is this at_least_until different from running two expectations in sequence, like:

expect_execution { ACTIONS }
   .to do
       maintain ....
       emit
    end

expect_execution.to do
    other_predicates_after_the_event_emission
end

[g-arjones]

I guess it can be done with multiple expectations + execution settings (if one wants to run this during configure/start). It's syntactic sugar that I may be adding in the wrong place?

[doudou]

It's syntactic sugar that I may be adding in the wrong place?

Not necessarily. I'm really trying to think about it. It was rather a "what do you think" kind of question.

So, maybe the right answer is "let's try it out and see what happens later" :P

[g-arjones]

Fair enough. I will add it in syskit and then we merge them both together.

[doudou]

You're making the difference between at_least and until in the user API (which is good) and then stop making it in this constructor to finally re-split on type...

Just propagate the same two arguments to the constructor.

[g-arjones]

I didn't want to break the API

[doudou]

Please do, these are meant to be private. The public interface are the expectation API calls.

(and add a # @private documentation line with the Maintain class)

[doudou]

Doesn't this never match if neither @at_least* are set?

I would check on @deadline here since the condition is using it.

[g-arjones]

Doesn't this never match if neither @at_least* are set?

The user level API enforces one of them to be set (just as it did before this patch)

[doudou]

OK. Please add a comment explaining that, it will make things easier on the understanding.

[doudou]

I would assume the caller would want the predicate to at least match once. Not sure what's your use-case though.

[g-arjones]

Good point. Will fix.