Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement reading ports via the new Async implementation (on top of #450) #451

Merged
merged 16 commits into from
Jan 29, 2025

Conversation

doudou
Copy link
Member

@doudou doudou commented Dec 30, 2024

On top of #450

#450 creates the general structure and make sure syskit telemetry ui can discover tasks. This PR re-adds reading ports. Properties are still not read/displayed.

@doudou doudou requested a review from jhonasiv December 30, 2024 20:18
@doudou doudou force-pushed the telemetry_v2_port_read branch 2 times, most recently from f0d5cb2 to c031d3e Compare January 3, 2025 20:09
@doudou doudou force-pushed the telemetry_v2_port_read branch from c031d3e to fa0543a Compare January 28, 2025 00:32
@doudou doudou force-pushed the new_async_implementation branch from 5c2071e to d5bb419 Compare January 28, 2025 00:32
@doudou doudou force-pushed the telemetry_v2_port_read branch from fa0543a to 6e931e9 Compare January 28, 2025 00:47
@doudou doudou force-pushed the new_async_implementation branch from d5bb419 to 3033516 Compare January 28, 2025 00:47
@doudou doudou force-pushed the telemetry_v2_port_read branch from 6e931e9 to 0eb1314 Compare January 28, 2025 01:03
@doudou doudou force-pushed the new_async_implementation branch from 3033516 to 098cfcd Compare January 28, 2025 01:03
Base automatically changed from new_async_implementation to transition-to-runkit January 28, 2025 23:53
doudou added 16 commits January 29, 2025 09:02
It is an costly, obsolete behaviour that is unneeded in this case.
This commits adapts/adds new calls to please Vizkit. The most important change
is that the initialization of the state values is now done by the port manager
instead of synchronously. This is made necessary as the task inspector registers
a callback on the state change before it does on reachability, leading sometimes
to having the state remaining INITIALIZING
This allows to "spread" the pollers instead of potentially having all of them
synchronized
The latter is essentially the former with smoe parameters fixed, such
as max_threads, in a way that is not overridable
This is expected by the current Vizkit implementation
@doudou doudou force-pushed the telemetry_v2_port_read branch from 0eb1314 to de8ddee Compare January 29, 2025 12:03
@doudou doudou merged commit f13fc9f into transition-to-runkit Jan 29, 2025
@doudou doudou deleted the telemetry_v2_port_read branch January 29, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants