-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement reading ports via the new Async implementation (on top of #450) #451
Merged
+1,579
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhonasiv
approved these changes
Jan 3, 2025
f0d5cb2
to
c031d3e
Compare
c031d3e
to
fa0543a
Compare
5c2071e
to
d5bb419
Compare
fa0543a
to
6e931e9
Compare
d5bb419
to
3033516
Compare
6e931e9
to
0eb1314
Compare
3033516
to
098cfcd
Compare
Base automatically changed from
new_async_implementation
to
transition-to-runkit
January 28, 2025 23:53
It is an costly, obsolete behaviour that is unneeded in this case.
This commits adapts/adds new calls to please Vizkit. The most important change is that the initialization of the state values is now done by the port manager instead of synchronously. This is made necessary as the task inspector registers a callback on the state change before it does on reachability, leading sometimes to having the state remaining INITIALIZING
This allows to "spread" the pollers instead of potentially having all of them synchronized
The latter is essentially the former with smoe parameters fixed, such as max_threads, in a way that is not overridable
This is expected by the current Vizkit implementation
0eb1314
to
de8ddee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #450
#450 creates the general structure and make sure
syskit telemetry ui
can discover tasks. This PR re-adds reading ports. Properties are still not read/displayed.