Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: log transfer/transfer_server CLI commands #457

Merged
merged 5 commits into from
Jan 29, 2025

Conversation

kapeps
Copy link

@kapeps kapeps commented Jan 28, 2025

The Transfer command was passing a hash instead of the FTPParameters, and passing the path instead of the certificate, and the server was not running, only being created.

Tested it by creating an RSA private key:
openssl genrsa -out rsa_private_key 2048

then a certificate:
openssl req -new -x509 -key rsa_private_key -out certificate.pem -subj "/CN=127.0.0.1"

then the required certfile:
cat rsa_private_key certificate.pem > certfile.pem

Then ran the server:
syskit log_runtime_archive transfer_server /home/kappes/test/transfer_dir/ 127.0.0.1 2124 /home/user/test/certfile user pwd true

Then transfered files:
syskit log_runtime_archive transfer 127.0.0.1 2124 /home/user/test/log_dir/ /home/user/test/certificate.pem user pwd true

#453 was mistakenly closed when deleting the branch it was on top of...

@kapeps kapeps requested review from doudou and wvmcastro January 28, 2025 12:42
@kapeps kapeps self-assigned this Jan 28, 2025
@kapeps kapeps force-pushed the fix_log_runtime_main branch from 40909b5 to 8482e73 Compare January 28, 2025 19:04
@kapeps kapeps merged commit 93faaf8 into transition-to-runkit Jan 29, 2025
@kapeps kapeps deleted the fix_log_runtime_main branch January 29, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants