Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add path parameter to IPASizeProvider #74

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

wacumov
Copy link

@wacumov wacumov commented Oct 5, 2021

Fixes #64.

Copy link
Contributor

@rogerluan rogerluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wacumov thanks for your contribution!
Could you update the tests for this new feature? 😊🙏

Copy link
Contributor

@rogerluan rogerluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks once again 🎉
@rockbruno gonna leave the final review for you 💪

@@ -1,9 +1,16 @@
import Foundation

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

***eezy12
login

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updated to use the output_directory from gym if provided
3 participants