Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub workflow multiple vim version #153

Merged
merged 2 commits into from
Sep 15, 2024

Conversation

shadowwa
Copy link
Contributor

  • update github action to prevent warning on action run. Had to define python version to prevent another warning, I used 3.10 as it's the version of ubuntu 22.04LTS currently used by github.
  • allow to have several versions of vim or nvim tested (unfortunatly, neovim below 0.9.0 segfault, even when trying to install the apt version available)

@lelutin
Copy link
Collaborator

lelutin commented Sep 15, 2024

THANKS! ❤️ I've been meaning to do exactly this change in the past few days but haven't reached that yet.

it's too bad for the previous versions of nvim -- the segfault was exactly my experience with it before, which is why nvim was just removed entirely from CI for a good while -- but at least we can test starting with 0.9 which is good.

do you think we could also add nvim 0.10.x to the matrix? debian unstable and ubuntu (I think? packages.ubuntu.com is not responding right now) still ship 0.9.5 but fedora has had 0.10.1 for a little while

edit: err scratch that.. I had apparently not looked correctly. nvim 0.10.1 is already in the list

@lelutin
Copy link
Collaborator

lelutin commented Sep 15, 2024

apparently this uncovers issues in epuppet ftdetect tests with vim 8.0

  • the type auto-discovery goes to 'mason' instead of 'epuppet'
  • somehow the default type of 'sh' is not there

This does not cause the bugs to exist, just uncovers it. I'll merge as-is and then open an issue for the vim 8.0 issues

@lelutin lelutin merged commit 10bf0b2 into rodjek:master Sep 15, 2024
6 of 7 checks passed
@shadowwa shadowwa deleted the github-workflow-multiple-vim-version branch September 22, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants