Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ajout du stockage HTTP dans Storage #34

Merged
merged 11 commits into from
Jul 7, 2023
Merged

Ajout du stockage HTTP dans Storage #34

merged 11 commits into from
Jul 7, 2023

Conversation

CorentinPeutin
Copy link
Contributor

@CorentinPeutin CorentinPeutin commented Apr 13, 2023 •
edited
Loading

Summary

Ajout du type de stockage HTTP.

[Changed]

  • Storage
    • Ajout de la copie de HTTP vers FILE/S3/CEPH
    • Ajout de la fonction de lecture d'un fichier HTTP, de l'existence d'un fichier HTTP et du calcul de taille d'un fichier HTTP

@CorentinPeutin CorentinPeutin linked an issue Apr 13, 2023 that may be closed by this pull request
Ajout du type de stockage HTTP #19
Closed
2 tasks
XavDmz
XavDmz reviewed Apr 17, 2023
View reviewed changes
Copy link
Contributor

@XavDmz XavDmz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quelques coquilles mais celle-ci concernent de la documentation ou des choix de chaînes bidon dans les tests unitaires.
Vu l'absence d'incidence, je ne pense pas qu'il soit nécessaire de les corriger avant la fusion. Ce serait mieux pour ne pas l'oublier après coup, mais pas indispensable.

src/rok4/Storage.py Outdated Show resolved Hide resolved
src/rok4/Storage.py Outdated Show resolved Hide resolved
tests/test_Storage.py Outdated Show resolved Hide resolved
XavDmz
XavDmz approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@XavDmz XavDmz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK pour moi

@github-actions github-actions bot added enhancement New feature or request quality labels Jul 7, 2023
@Dolite Dolite merged commit 318b8a0 into develop Jul 7, 2023
1 check passed
@Dolite Dolite deleted the feature/stockage_HTTP branch July 7, 2023 14:28
@Dolite Dolite added this to the 1.7.0 milestone Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XavDmz XavDmz XavDmz approved these changes

@Dolite Dolite Awaiting requested review from Dolite

Assignees
No one assigned
Labels
enhancement New feature or request quality
Projects
None yet
Milestone
1.7.1
Development

Successfully merging this pull request may close these issues.

Ajout du type de stockage HTTP
3 participants
@CorentinPeutin @XavDmz @Dolite