Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle extension using esbuild #335

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Bundle extension using esbuild #335

wants to merge 11 commits into from

Conversation

TwitchBronBron
Copy link
Member

@TwitchBronBron TwitchBronBron commented Nov 5, 2021 •
edited
Loading

This uses esbuild to bundle the application.

  • esbuild is extremely fast. The entire build takes like ~200ms.
  • bundling tree shakes all unused modules so we get a super small build

Here are some rough metrics of how this improves the process:

  • original vsix: 18.6MB
  • esbuild vsix: 1.5MB

This replaces #200 because webpack is too slow. :P

Outstanding issues:

  • fix language server not working
  • figure out npm symlinked debugging workflows for language server and debugger
  • lots of testing to verify everything still works
  • figure out how to properly test this flow since the unit tests don't use the esbuild version

@TwitchBronBron TwitchBronBron mentioned this pull request Nov 5, 2021
Closed
@TwitchBronBron TwitchBronBron added the create-vsix PRs with this tag will trigger a vsix build on vscode-brightscript-language for every push label Nov 5, 2021
@rokucommunity-bot
Copy link

Hey there! I just built a new version of the vscode extension based on 63cca47. You can downloaded the .vsix here and then follow these installation instructions.

@TwitchBronBron TwitchBronBron mentioned this pull request Mar 2, 2022
Closed
@rokucommunity-bot
Copy link

Hey there! I just built a new version of the vscode extension based on 3e0cc58. You can downloaded the .vsix here and then follow these installation instructions.

@rokucommunity-bot
Copy link

Hey there! I just built a new version of the vscode extension based on acedc1b. You can downloaded the .vsix here and then follow these installation instructions.

@rokucommunity-bot
Copy link

Hey there! I just built a new version of the vscode extension based on f12d5cf. You can downloaded the .vsix here and then follow these installation instructions.

@rokucommunity-bot
Copy link

Hey there! I just built a new version of the vscode extension based on 31752ae. You can downloaded the .vsix here and then follow these installation instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanGillis NathanGillis NathanGillis approved these changes

Assignees
No one assigned
Labels
create-vsix PRs with this tag will trigger a vsix build on vscode-brightscript-language for every push
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TwitchBronBron @NathanGillis