Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSD: Widget Hero #513

Closed
ansivgit opened this issue Sep 12, 2024 · 0 comments
Closed

FSD: Widget Hero #513

ansivgit opened this issue Sep 12, 2024 · 0 comments

Comments

@ansivgit
Copy link
Collaborator

ansivgit commented Sep 12, 2024

πŸ“ Describe the refactoring task

Part of the issue #347
Hero & Main components refactor

Related issues:
#334
#515
#541

Closes issues:
#334
#540
#515

πŸ“ Code location

src/widgets/hero/ui/hero.tsx
src/widgets/main/ui

βœ… Definition of Done (DoD):

  1. rename file hero.tsx component to hero-page.tsx
  2. change the HeroPage component structure so we can use it on pages School, Courses and Community
  3. change imports main.tsx to hero-page.tsx on all pages
  4. remove folder main
  5. Refactor hero-page.tsx scss to scss-modules including:
  • remove all parent selector & .card-content -> .card-content.
  • change all possible values to variables if such exists.
  • rename all classes to be generic e.g .nodejs-trainer πŸ™…β€β™‚οΈ -> .trainer πŸ‘Œ.
  • and everything in your opinion that needs to be refactored
  1. refactor JSX to utilize HTML5 tags
  2. add unit test for hero-page.tsx inside ui folder
  3. re-export component as HeroPage
@ansivgit ansivgit self-assigned this Sep 12, 2024
@ansivgit ansivgit changed the title hero FSD: Widget Hero Sep 12, 2024
@ansivgit ansivgit added this to RS Site Sep 12, 2024
@ansivgit ansivgit moved this to In Progress in RS Site Sep 12, 2024
This was referenced Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

1 participant