Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSD: Widget Hero Course #541

Closed
4 tasks
ansivgit opened this issue Sep 23, 2024 · 1 comment
Closed
4 tasks

FSD: Widget Hero Course #541

ansivgit opened this issue Sep 23, 2024 · 1 comment

Comments

@ansivgit
Copy link
Collaborator

πŸ“ Describe the refactoring task

Part of the issue #347
Part of the issue #513
Hero components refactor

Related issues:
#513

Closes issues:
#513

πŸ“ Code location
src/widgets/course-main

βœ… Definition of Done (DoD):

[ ] rename file course-main.tsx component to hero-course.tsx
[ ] change imports to hero-course.tsx on all courses' pages
[ ] Refactor hero-course.tsx scss including:

  • remove all parent selector & .card-content -> .card-content.
  • change all possible values to variables if such exists.
  • rename all classes to be generic e.g .nodejs-trainer πŸ™…β€β™‚οΈ -> .trainer πŸ‘Œ.
  • and everything in your opinion that needs to be refactored

[ ] refactor JSX to utilize HTML5 tags
[ ] add/change unit test for HeroΠ‘ourse component
[ ] re-export component as HeroCourse

@ansivgit ansivgit added this to RS Site Sep 23, 2024
@ansivgit ansivgit moved this to Backlog in RS Site Sep 23, 2024
@ansivgit ansivgit self-assigned this Sep 23, 2024
@ansivgit ansivgit moved this from Backlog to In Progress in RS Site Sep 23, 2024
@ansivgit ansivgit changed the title FSD: Widget Hero Courses FSD: Widget Hero Course Sep 23, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in RS Site Sep 24, 2024
@ansivgit
Copy link
Collaborator Author

Duplicate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

1 participant