misc: Add support for WEB_CONCURRENCY environment variable #1633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamantike
added a commit
to adamantike/romm-wiki
that referenced
this pull request
Feb 19, 2025
`WEB_CONCURRENCY` replaces `GUNICORN_WORKERS` as the environment variable to set the number of processes running the web application. Depends on rommapp/romm#1633.
The `WEB_CONCURRENCY` environment variable is a more common way to configure the number of workers for Gunicorn [1] or other web servers. This change maintains `GUNICORN_WORKERS` compatibility, while notifying users that it is deprecated and should be replaced with `WEB_CONCURRENCY`. It would also allow us to replace Gunicorn with another web server in the future without changing the variable name. [1] https://docs.gunicorn.org/en/stable/settings.html#workers
adamantike
force-pushed
the
misc/add-WEB_CONCURRENCY-support
branch
from
37db031 to
9602d58
Compare
gantoine
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
WEB_CONCURRENCYenvironment variable is a more common way to configure the number of workers for Gunicorn [1] or other web servers.This change maintains
GUNICORN_WORKERScompatibility, while notifying users that it is deprecated and should be replaced withWEB_CONCURRENCY.It would also allow us to replace Gunicorn with another web server in the future without changing the variable name.
[1] https://docs.gunicorn.org/en/stable/settings.html#workers
Checklist
Please check all that apply.