misc: Strip environment variables related to third-party credentials #1650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For client_id/client_secret combinations, and API keys, we are certain that they should not have leading/trailing whitespaces. We can strip them to avoid any potential issues for users who might have added them incorrectly in their Docker Compose configuration. This change does NOT affect users/passwords, where leading/trailing whitespaces might be intentional and valid.
Test Results93 tests 93 ✅ 28s ⏱️ Results for commit fac3686. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For client_id/client_secret combinations, and API keys, we are certain that they should not have leading/trailing whitespaces. We can strip them to avoid any potential issues for users who might have added them incorrectly in their Docker Compose configuration.
This change does NOT affect users/passwords, where leading/trailing whitespaces might be intentional and valid.
Checklist
Please check all that apply.