feat(BridgeReward, BridgeTracking): improve sync reward in bridge reward #14
+696
−476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nxqbao
changed the title
nxqbao
force-pushed
the
feat/improve-sync-reward-in-bridge-reward
branch
from
7f4a17e to
7af7490
Compare
khanhtaskymaviscom
suggested changes
Mar 15, 2024
| if (pdCount == 0) revert ErrPeriodCountIsZero(); | ||
|
|
||
| // Not settle the period that already rewarded. | ||
| if (currPd <= lastRewardPd + 1) revert ErrPeriodAlreadyRewarded(currPd, lastRewardPd); |
There was a problem hiding this comment.
This line is not necessary as pdCount must be >= 1 (as last condition), combined with the following validation is sufficient.
There was a problem hiding this comment.
noted, but I leave it unchanged, added in-line comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist