feat(AssetMigration): add implement for AssetMigration and FunctionRestrictable
#88
+864
−278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TuDo1403
force-pushed
the
feature/asset-migration
branch
from
c7e7e72 to
d1ae509
Compare
TuDo1403
force-pushed
the
feature/asset-migration
branch
from
d1ae509 to
0330d4f
Compare
huyhuynh3103
reviewed
Dec 5, 2024
huyhuynh3103
reviewed
Dec 5, 2024
huyhuynh3103
requested changes
Dec 5, 2024
huyhuynh3103
reviewed
Dec 5, 2024
Co-authored-by: HuyHuynh <[email protected]> Signed-off-by: tu-do.ron <[email protected]>
thaixuandang
reviewed
Dec 5, 2024
TuDo1403
commented
Dec 5, 2024
Signed-off-by: tu-do.ron <[email protected]>
…to set whitelist, add functional pausable module
Co-authored-by: HuyHuynh <[email protected]> Signed-off-by: tu-do.ron <[email protected]>
Signed-off-by: tu-do.ron <[email protected]>
Signed-off-by: tu-do.ron <[email protected]>
minh-bq
reviewed
Dec 20, 2024
| @@ -58,81 +61,16 @@ contract MainchainGatewayV3 is | |||
| _disableInitializers(); | |||
| } | |||
|
|
|||
| fallback() external payable { | |||
There was a problem hiding this comment.
Any requirement for this? Otherwise should not remove.
There was a problem hiding this comment.
an attempt to reduce code size, we also do not need this function too.
There was a problem hiding this comment.
I think it's not necessary (just a few bytes) and might break things. Please do not remove it.
There was a problem hiding this comment.
If this function is kept, the current restrict logic can be bypassed using this function to create a deposit when deposit is restricted.
…fn into one, split it to other contract for testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements:
AssetMigration Module
migrateERC20: migrate specific amount of ERC20 tokens to whitelisted address.** note **: native will be wrapped into WETH, therefore while whitelisting, ensure to whitelist wrapped ERC20 address, instead of address(0).
FunctionRestrictable Module
restrict(bytes4, uint8): allow pause specific function with specific token standard.Checklist