Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(BridgeManager): require min governors in manager #9

Merged
merged 3 commits into from
Mar 25, 2024
Merged

feat(BridgeManager): require min governors in manager #9

merged 3 commits into from
Mar 25, 2024

Conversation

nxqbao
Copy link
Contributor

@nxqbao nxqbao commented Mar 6, 2024

Description

  • BridgeManager always have at least 3 governors/operators
  • Expose setter to this config.

Checklist

  • I have clearly commented on all the main functions following the NatSpec Format
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works

khanhtaskymaviscom
khanhtaskymaviscom approved these changes Mar 14, 2024
View reviewed changes
Copy link

@khanhtaskymaviscom khanhtaskymaviscom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Base automatically changed from feat/reduce-gas-rework to release/v3.1.0 March 25, 2024 03:32
@nxqbao nxqbao merged commit 3796473 into release/v3.1.0 Mar 25, 2024
@nxqbao nxqbao deleted the feat/require-min-governors-in-manager branch March 25, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khanhtaskymaviscom khanhtaskymaviscom khanhtaskymaviscom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nxqbao @khanhtaskymaviscom