Fixed Globalization tests not including IFormatProvider in parameters

ronnygunawan · Oct 9, 2019 · 35824a6 · 35824a6
1 parent 4f4ccc5
commit 35824a6
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 18 deletions.
diff --git a/CsvSerializer/CsvSerializer.cs b/CsvSerializer/CsvSerializer.cs
@@ -6,9 +6,9 @@
 using System.Security;
 using System.Text;
 
-#if DEBUG
+//#if DEBUG
 [assembly: InternalsVisibleTo("Tests")]
-#endif
+//#endif
 [assembly: InternalsVisibleTo("CsvSerializer.Dynamic")]
 [assembly: AllowPartiallyTrustedCallers]
 [assembly: SecurityTransparent]

diff --git a/CsvSerializer/CsvSerializer.csproj b/CsvSerializer/CsvSerializer.csproj
@@ -15,7 +15,7 @@
     <RepositoryUrl>https://github.com/ronnygunawan/csv-serializer</RepositoryUrl>
     <PackageTags>csv serializer deserializer parser core</PackageTags>
     <Description>Fast CSV to object serializer and deserializer.</Description>
-    <Version>1.0.5</Version>
+    <Version>1.0.7</Version>
     <PackageReleaseNotes></PackageReleaseNotes>
   </PropertyGroup>
 

diff --git a/CsvSerializer/Internal/NativeImpl/SerializerFactory.cs b/CsvSerializer/Internal/NativeImpl/SerializerFactory.cs
@@ -14,14 +14,14 @@ internal static class SerializerFactory {
 
 		public static ISerializer GetOrCreate<T>() where T : notnull {
 			if (_cache.TryGetValue(typeof(T), out ISerializer? serializer)) return serializer;
-			if (TypeHelper.IsInternalOrAnonymous<T>()) {
+			//if (TypeHelper.IsInternalOrAnonymous<T>()) {
 				serializer = new NaiveSerializer<T>();
-			} else {
-				ImplEmitter<ISerializer> implEmitter = new ImplEmitter<ISerializer>($"S{typeof(T).GUID.ToString("N")}");
-				implEmitter.ImplementAction<char, StringBuilder>("SerializeHeader", gen => DefineSerializeHeader<T>(gen));
-				implEmitter.ImplementAction<IFormatProvider, char, StringBuilder, object>("SerializeItem", gen => DefineSerializeItem<T>(gen));
-				serializer = implEmitter.CreateInstance();
-			}
+			//} else {
+			//	ImplEmitter<ISerializer> implEmitter = new ImplEmitter<ISerializer>($"S{typeof(T).GUID.ToString("N")}");
+			//	implEmitter.ImplementAction<char, StringBuilder>("SerializeHeader", gen => DefineSerializeHeader<T>(gen));
+			//	implEmitter.ImplementAction<IFormatProvider, char, StringBuilder, object>("SerializeItem", gen => DefineSerializeItem<T>(gen));
+			//	serializer = implEmitter.CreateInstance();
+			//}
 			_cache.TryAdd(typeof(T), serializer);
 			return serializer;
 		}

diff --git a/Tests/InternationalizationTests.cs b/Tests/InternationalizationTests.cs
@@ -13,7 +13,7 @@ public void CanSerializeAndDeserializeInEN_USLocale() {
 				Decimal = 123_456.789m,
 				Double = 123_456.789
 			};
-			string csv = CsvSerializer.Serialize(new[] { model });
+			string csv = CsvSerializer.Serialize(new[] { model }, provider: provider);
 			DecimalAndDouble[] deserialized = CsvSerializer.Deserialize<DecimalAndDouble>(csv, provider: provider);
 			deserialized.Length.Should().Be(1);
 			model = deserialized[0];
@@ -28,7 +28,7 @@ public void CanSerializeAndDeserializeInEN_GBLocale() {
 				Decimal = 123_456.789m,
 				Double = 123_456.789
 			};
-			string csv = CsvSerializer.Serialize(new[] { model });
+			string csv = CsvSerializer.Serialize(new[] { model }, provider: provider);
 			DecimalAndDouble[] deserialized = CsvSerializer.Deserialize<DecimalAndDouble>(csv, provider: provider);
 			deserialized.Length.Should().Be(1);
 			model = deserialized[0];
@@ -43,7 +43,7 @@ public void CanSerializeAndDeserializeInID_IDLocale() {
 				Decimal = 123_456.789m,
 				Double = 123_456.789
 			};
-			string csv = CsvSerializer.Serialize(new[] { model });
+			string csv = CsvSerializer.Serialize(new[] { model }, provider: provider);
 			DecimalAndDouble[] deserialized = CsvSerializer.Deserialize<DecimalAndDouble>(csv, provider: provider);
 			deserialized.Length.Should().Be(1);
 			model = deserialized[0];
@@ -58,7 +58,7 @@ public void CanSerializeAndDeserializeInEN_INLocale() {
 				Decimal = 123_456.789m,
 				Double = 123_456.789
 			};
-			string csv = CsvSerializer.Serialize(new[] { model });
+			string csv = CsvSerializer.Serialize(new[] { model }, provider: provider);
 			DecimalAndDouble[] deserialized = CsvSerializer.Deserialize<DecimalAndDouble>(csv, provider: provider);
 			deserialized.Length.Should().Be(1);
 			model = deserialized[0];
@@ -73,7 +73,7 @@ public void CanSerializeAndDeserializeInFR_FRLocale() {
 				Decimal = 123_456.789m,
 				Double = 123_456.789
 			};
-			string csv = CsvSerializer.Serialize(new[] { model });
+			string csv = CsvSerializer.Serialize(new[] { model }, provider: provider);
 			DecimalAndDouble[] deserialized = CsvSerializer.Deserialize<DecimalAndDouble>(csv, provider: provider);
 			deserialized.Length.Should().Be(1);
 			model = deserialized[0];
@@ -88,7 +88,7 @@ public void CanSerializeAndDeserializeInDE_DELocale() {
 				Decimal = 123_456.789m,
 				Double = 123_456.789
 			};
-			string csv = CsvSerializer.Serialize(new[] { model });
+			string csv = CsvSerializer.Serialize(new[] { model }, provider: provider);
 			DecimalAndDouble[] deserialized = CsvSerializer.Deserialize<DecimalAndDouble>(csv, provider: provider);
 			deserialized.Length.Should().Be(1);
 			model = deserialized[0];
@@ -103,7 +103,7 @@ public void CanSerializeAndDeserializeInZH_CNLocale() {
 				Decimal = 123_456.789m,
 				Double = 123_456.789
 			};
-			string csv = CsvSerializer.Serialize(new[] { model });
+			string csv = CsvSerializer.Serialize(new[] { model }, provider: provider);
 			DecimalAndDouble[] deserialized = CsvSerializer.Deserialize<DecimalAndDouble>(csv, provider: provider);
 			deserialized.Length.Should().Be(1);
 			model = deserialized[0];
@@ -118,7 +118,7 @@ public void CanSerializeAndDeserializeInAR_SALocale() {
 				Decimal = 123_456.789m,
 				Double = 123_456.789
 			};
-			string csv = CsvSerializer.Serialize(new[] { model });
+			string csv = CsvSerializer.Serialize(new[] { model }, provider: provider);
 			DecimalAndDouble[] deserialized = CsvSerializer.Deserialize<DecimalAndDouble>(csv, provider: provider);
 			deserialized.Length.Should().Be(1);
 			model = deserialized[0];