Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed a fix for RTL language support in pdf.js and found some issues pulling in a more recent version:
I've updated the readme to make it clear what version of PDF.js is supported with these changes, since it seems that V4 will require a fairly significant overhaul
RE: the global
require
"hacks", I'm not sure how it worked before, but the existing require calls in parse-cmd were not makingpdfjsLib
available so i added an explicit require call topdf-table-extractor.js
. This tells me that the require for domstubs might not be necessary but I didn't check that since the code as-is works for my needs.