core: make rook version more readable #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subhamkrai
force-pushed
the
make-rook-version-more-readable
branch
from
16bad81
to
d696d1f
Compare
|
earlier now |
travisn
reviewed
Jun 14, 2023
cmd/commands/root.go
Outdated
| @@ -106,7 +107,11 @@ func PreValidationCheck(ctx context.Context, k8sclientset *k8sutil.Clientsets, o | |||
| } | |||
|
|
|||
| rookVersion := exec.RunCommandInOperatorPod(ctx, k8sclientset, "rook", []string{"version"}, operatorNamespace, cephClusterNamespace, true, false) | |||
| re := regexp.MustCompile("(?m)[\r\n]+^.*go: go.*$") // remove the go version from the output | |||
| rookVersion = re.ReplaceAllString(rookVersion, "") | |||
There was a problem hiding this comment.
How about factoring out this string replacement to a small helper method, then add a unit test for it? Whenever there is a regular expression, a unit test is always helpful.
There was a problem hiding this comment.
added.
I want to add unit tests for all the methods but seems like that will take more time to release and require my bandwidth. XD
There was a problem hiding this comment.
Unit tests for now can avoid the high level commands since they are covered by the integration tests, but for small things like this, unit tests will be perfect.
there was extra `fmt.Print()` in method `RunCommandInOperatorPod` due to which command output was printed two times. fixes: rook#118 Signed-off-by: subhamkrai <[email protected]>
during pre-validation check, rook version was printed in multiple lines with golang version which was making it difficult to read. Now, it prints in one single like with the golang version. Also, adding unit test for the regular expression. Signed-off-by: subhamkrai <[email protected]>
subhamkrai
force-pushed
the
make-rook-version-more-readable
branch
from
b9a1cea
to
8c63fee
Compare
travisn
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core: make rook version more readable
during pre-validation check, rook version was
printed in multiple lines with golang version
which was making it difficult to read. Now, it
prints in one single like with the golang version.
core: print version info only once
there was extra
fmt.Print()in methodRunCommandInOperatorPoddue to which command output was printed two times.
fixes: #118
Signed-off-by: subhamkrai [email protected]