Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cling] Ensure correct template argument printing for large integers #17867

Closed
wants to merge 3 commits into from

Conversation

devajithvs
Copy link
Contributor

@devajithvs devajithvs commented Mar 3, 2025

This Pull request:

We do not need a patch to set ULL suffix manually on top of Clang.

Policy.AlwaysIncludeTypeForTemplateArgument = true does the job.

This will get rid of the patch: root-project/llvm-project@5ae1304

I started the process of upstreaming (llvm/llvm-project#129235).
But on further digging, I realized we can simply use AlwaysIncludeTypeForTemplateArgument = true

Changes or fixes:

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

This PR fixes #

We do not need a patch to set `ULL` suffix manually on top of Clang.

`Policy.AlwaysIncludeTypeForTemplateArgument = true` does the job.
@devajithvs devajithvs requested a review from hahnjo March 3, 2025 14:45
@devajithvs devajithvs self-assigned this Mar 3, 2025
@devajithvs devajithvs marked this pull request as draft March 3, 2025 16:01
@pcanal
Copy link
Member

pcanal commented Mar 3, 2025

Policy.AlwaysIncludeTypeForTemplateArgument = true does the job.

Does that also change the way smaller numbers are printed?

@devajithvs
Copy link
Contributor Author

Does that also change the way smaller numbers are printed?

Yes. I realized that only after the tests failed. I'll try to figure out something.

Copy link

github-actions bot commented Mar 3, 2025

Test Results

    17 files      17 suites   4d 8h 34m 3s ⏱️
 2 725 tests  2 714 ✅ 0 💤 11 ❌
44 721 runs  44 634 ✅ 0 💤 87 ❌

For more details on these failures, see this check.

Results for commit 70787ce.

♻️ This comment has been updated with latest results.

@devajithvs
Copy link
Contributor Author

Closing this as it will be a breaking change (can reopen this at a later stage when we really want to get rid of all the clang patches)

@devajithvs devajithvs closed this Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants