[tree] Avoid stack-use-after-scope by also resetting friends branch addresses #17886
+44
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferdymercury
commented
Mar 5, 2025
vepadulano
approved these changes
Mar 5, 2025
There was a problem hiding this comment.
This looks sensible to do to me! Let's also wait for @pcanal's opinion. Thank you for such a thorough investigation!
Co-authored-by: Vincenzo Eduardo Padulano <[email protected]>
ferdymercury
commented
Mar 5, 2025
Test Results 18 files 18 suites 4d 14h 48m 47s ⏱️ For more details on these failures, see this check. Results for commit ca0e779. ♻️ This comment has been updated with latest results. |
pcanal
reviewed
Mar 5, 2025
as suggested by pcanal
2 tasks
|
Hi @ferdymercury , I believe you can merge this PR, or I will go ahead if you prefer! |
|
Thanks Vincenzo! I have no merge rights, so please go ahead;) an remember squash on merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Fixes #17843
Checklist: