Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update componentWillMount to componentDidMount #376

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

update componentWillMount to componentDidMount #376

wants to merge 2 commits into from

Conversation

jeffraux
Copy link

See Issue #375

@jeffraux jeffraux mentioned this pull request Sep 23, 2019
Open
@adooylabs
Copy link

@jeffraux -- I think it better to use getDerivedStateFromProps

@abhishrek
Copy link

Any plans to merge this ?
The Yellow Warnings about componentWillMount is annoying.

@Makgora
Copy link

Makgora commented Jun 29, 2020

Up

@mineshpatel1
Copy link

+1

1 similar comment
@leonimurilo
Copy link

+1

@josedaesbar
Copy link

Any news on this warning?

@zamudio-nextie
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jeffraux @adooylabs @abhishrek @Makgora @mineshpatel1 @leonimurilo @josedaesbar @zamudio-nextie