Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing JQuery dependency #8

Open
jhiemer opened this issue Aug 7, 2013 · 5 comments
Open

Removing JQuery dependency #8

jhiemer opened this issue Aug 7, 2013 · 5 comments

Comments

@jhiemer
Copy link

jhiemer commented Aug 7, 2013

Is it possible to remove the JQuery dependency?

@clouddueling
Copy link

Highcharts recently did this. It's called like Highcharts Framework or something but they became independent of jQuery.

@jhiemer
Copy link
Author

jhiemer commented Aug 17, 2013

@clouddueling that's not what I meant. The directive currently uses JQuery here:

https://github.com/rootux/angular-highcharts-directive/blob/master/src/directives/highchart.js#L33

@clouddueling
Copy link

I hope this project isn't dead but I've since forked it and modified it on my own.

I use angular.extend instead:
https://gist.github.com/clouddueling/6270582

@rootux
Copy link
Owner

rootux commented Sep 5, 2013

This project isn't dead. I was just vacationning in the east.
@clouddueling Can I override my original $.extend with your angular.extend.
Since I'm using deep copy True with $.extend. isn't it better I use the angular.copy?

@clouddueling
Copy link

I updated the gist with my most recent version. https://gist.github.com/clouddueling/6270582
It was a straight replacement for $.extend.

Repository owner deleted a comment from chasedson Jan 24, 2024
Repository owner deleted a comment from Sayman71 Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants